fix: consumer-group scoped plugins not showing tags #485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On running deck file render command, tags were coming up for global and service/route scoped plugins. However, for consumer-group scoped plugins, the tags did not populate. This was because the underlying struct did not have tags in the first place. This change updates the underlying struct for consumer-group plugins by adding tags to them as well. This will ensure that tags show up during deck file render. For: Kong/deck#1417
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #485 +/- ##
=======================================
Coverage 55.15% 55.15%
=======================================
Files 71 71
Lines 5691 5691
=======================================
Hits 3139 3139
Misses 1935 1935
Partials 617 617
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On running deck file render command, tags were
coming up for global and service/route scoped
plugins. However, for consumer-group scoped
plugins, the tags did not populate. This was because the underlying struct did not have tags in the first place.
This change updates the underlying struct for
consumer-group plugins by adding tags to them
as well. This will ensure that tags show up
during deck file render.
For: Kong/deck#1417